hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom White (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-2325) Mark o.a.h.mapreduce.TaskReport as public?
Date Thu, 24 Feb 2011 05:42:38 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998700#comment-12998700
] 

Tom White commented on MAPREDUCE-2325:
--------------------------------------

Public/Evolving is fine for the enums. Also, the downgrade/upgrade methods look good (and
are consistent with the way a similar thing is done in Counters, for example). I would make
these methods package private (or mark them as Private if that's not possible), since they
are not a part of the public API.

A couple of nits: the indentation should be 2 spaces (you have 4 in places); and the brace
style in the downgrade and upgrade methods is different to the usual style in the rest of
the code.

Can you run test patch and the unit tests? Let me know if you need any help doing so (normally
Hudson would run this when marked as patch available, but I'm not sure it's running at the
moment).



> Mark o.a.h.mapreduce.TaskReport as public?
> ------------------------------------------
>
>                 Key: MAPREDUCE-2325
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2325
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.21.0
>            Reporter: Tim Yates
>            Priority: Minor
>         Attachments: MAPREDUCE-2325.patch, MAPREDUCE-2325.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> o.a.h.mapreduce.TaskReport is returned by Job.getTaskReports(TaskType), which is marked
as Public/Evolving. TaskReport, however, is marked as Private. This looks like an oversight:
The last time it was mentioned in HADOOP-1623, Tom White [suggested|https://issues.apache.org/jira/browse/MAPREDUCE-1623?focusedCommentId=12863494&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12863494]
that it should be Public, but all of the patches continued to use Private.
> If this _isn't_ supposed to be public, where is the best place to get the list of running
tasks (not just completed ones)?

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message