hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mahadev konar (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-2335) mapreduce.CounterGroup constructor should not be public
Date Thu, 17 Feb 2011 23:45:12 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996153#comment-12996153
] 

Mahadev konar commented on MAPREDUCE-2335:
------------------------------------------

+1 for making it package private.

> mapreduce.CounterGroup constructor should not be public
> -------------------------------------------------------
>
>                 Key: MAPREDUCE-2335
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2335
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Luke Lu
>
> MAPREDUCE-980 (made into 0.21+) changed the constructor from package protected to public.
As we all know: nothing good happens after making a constructor public, especially for public
facing APIs. There is no other use of the constructor outside the EventReader yet. To avoid
another API change debacle in case of external user usage and later we decide to refactor
counters for more efficient internal implementations (e.g. a la MAPREDUCE-901), we should
make the Counter/CounterGroup constructors package private, and provide a method to addGroup
to Counters. Or at least make the constructor @InterfaceAudience.Private.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message