hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Priyo Mustafi (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1915) IndexCache - getIndexInformation - check reduce index Out Of Bounds
Date Fri, 04 Feb 2011 02:31:23 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990430#comment-12990430
] 

Priyo Mustafi commented on MAPREDUCE-1915:
------------------------------------------

     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     -1 release audit.  The applied patch generated 20 release audit warnings (more
than the trunk's current 1 warnings).
     [exec] 
     [exec]     +1 system test framework.  The patch passed system test framework compile.


> IndexCache - getIndexInformation - check reduce index Out Of Bounds
> -------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1915
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1915
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tasktracker
>    Affects Versions: 0.20.1, 0.20.2, 0.20.3, 0.21.0, 0.22.0
>            Reporter: Rares Vernica
>            Assignee: Priyo Mustafi
>            Priority: Trivial
>             Fix For: 0.22.0
>
>         Attachments: MAPREDUCE-1915.patch, MAPREDUCE-1915_1.patch
>
>
> When checking if the "reduce" index is out of bounds the check should be 
> info.mapSpillRecord.size() <= reduce
> instead of:
> info.mapSpillRecord.size() < reduce
> Not a big bug since an Out Of Bounds is thrown downstream anyway.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message