hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Yates (JIRA)" <j...@apache.org>
Subject [jira] Updated: (MAPREDUCE-2325) Mark o.a.h.mapreduce.TaskReport as public?
Date Wed, 23 Feb 2011 22:55:38 GMT

     [ https://issues.apache.org/jira/browse/MAPREDUCE-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Tim Yates updated MAPREDUCE-2325:

    Attachment: MAPREDUCE-2325.patch

I followed your suggestion, creating a new enum and moving the old method to the old class.
A few questions:
- I made both enums Public/Evolving. Is this reasonable?
- I added a standard downgrade() method to o.a.h.mapred.TIPStatus. Because this is an enum
and you can't simply upcast to o.a.h.mapreduce.TIPStatus, I also added an upgrade() method:
-- Are there better or more standard alternatives? Have you encountered this problem elsewhere?
-- Is this method in the right place (the old enum, like downgrade)?
-- Should it be a static method (like downgrade), or is an instance method better (like I
have now)?

The only code that this change seemed to affect was o.a.h.mapreduce.tools.CLI, which was an
easy fix. Everything else built fine on my system, including contrib.

> Mark o.a.h.mapreduce.TaskReport as public?
> ------------------------------------------
>                 Key: MAPREDUCE-2325
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2325
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.21.0
>            Reporter: Tim Yates
>            Priority: Minor
>         Attachments: MAPREDUCE-2325.patch, MAPREDUCE-2325.patch
>   Original Estimate: 1h
>  Remaining Estimate: 1h
> o.a.h.mapreduce.TaskReport is returned by Job.getTaskReports(TaskType), which is marked
as Public/Evolving. TaskReport, however, is marked as Private. This looks like an oversight:
The last time it was mentioned in HADOOP-1623, Tom White [suggested|https://issues.apache.org/jira/browse/MAPREDUCE-1623?focusedCommentId=12863494&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12863494]
that it should be Public, but all of the patches continued to use Private.
> If this _isn't_ supposed to be public, where is the best place to get the list of running
tasks (not just completed ones)?

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message