hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bhallamudi Venkata Siva Kamesh (JIRA)" <j...@apache.org>
Subject [jira] Created: (MAPREDUCE-2243) Close all the file streams propely in a finally block to avoid their leakage.
Date Wed, 05 Jan 2011 11:29:46 GMT
Close all the file streams propely in a finally block to avoid their leakage.
-----------------------------------------------------------------------------

                 Key: MAPREDUCE-2243
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2243
             Project: Hadoop Map/Reduce
          Issue Type: Improvement
          Components: jobtracker, tasktracker
    Affects Versions: 0.20.1, 0.22.0
         Environment: NA
            Reporter: Bhallamudi Venkata Siva Kamesh
            Priority: Minor
             Fix For: 0.22.0


In the following classes streams should be closed in finally block to avoid their leakage
in the exceptional cases.

CompletedJobStatusStore.java
------------------------------------------
       dataOut.writeInt(events.length);
        for (TaskCompletionEvent event : events) {
          event.write(dataOut);
        }
       dataOut.close() ;

EventWriter.java
----------------------
   encoder.flush();
   out.close();

MapTask.java
-------------------
    splitMetaInfo.write(out);
     out.close();

TaskLog
------------
 1) str = fis.readLine();
      fis.close();

2) dos.writeBytes(Long.toString(new File(logLocation, LogName.SYSLOG
      .toString()).length() - prevLogLength) + "\n");
    dos.close();

TotalOrderPartitioner.java
-----------------------------------
 while (reader.next(key, value)) {
	      parts.add(key);
	      key = ReflectionUtils.newInstance(keyClass, conf);
	    }
reader.close();




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message