hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1825) jobqueue_details.jsp and FairSchedulerServelet should not call finishedMaps and finishedReduces when job is not initialized
Date Fri, 28 Jan 2011 00:54:46 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987866#action_12987866
] 

Konstantin Shvachko commented on MAPREDUCE-1825:
------------------------------------------------

This looks good to me.
Writing a unit test would be hard here. But it can be manual testing, like holding a lock
in debugger and triggering webUI refresh, would be very useful.
+1 modular manual testing.
Nit. Please add empty line before {{FairSchedulerServlet.getInitedJobs()}}

> jobqueue_details.jsp and FairSchedulerServelet should not call finishedMaps and finishedReduces
when job is not initialized
> ---------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1825
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1825
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobtracker
>    Affects Versions: 0.20.1
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Scott Chen
>         Attachments: MAPREDUCE-1825.txt, MAPREDUCE-1825_1.txt
>
>
> JobInProgress.finishedMaps() and finishedReduces() are synchronized. They are called
from jobqueue_details.jsp and FairSchedulerServelet which iterates through all jobs. If any
job is in initialization, these pages don't come up until the initialization finishes.
> See [comment|https://issues.apache.org/jira/browse/MAPREDUCE-1354?focusedCommentId=12834139&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12834139]
for more details

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message