hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-2256) FairScheduler fairshare preemption from multiple pools may preempt all tasks from one pool causing that pool to go below fairshare.
Date Fri, 28 Jan 2011 07:21:45 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987968#action_12987968
] 

Hadoop QA commented on MAPREDUCE-2256:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12468031/mapreduce-2256_0_22.txt
  against trunk revision 1064287.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/19//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/19//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/19//console

This message is automatically generated.

> FairScheduler fairshare preemption from multiple pools may preempt all tasks from one
pool causing that pool to go below fairshare.
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2256
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2256
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: contrib/fair-share
>    Affects Versions: 0.21.1, 0.22.0
>            Reporter: Priyo Mustafi
>            Assignee: Priyo Mustafi
>             Fix For: 0.22.0
>
>         Attachments: mapreduce-2256_0_22.txt
>
>
> Scenarios:
> You have a cluster with 600 map slots and 3 pools.  Fairshare for each pool is 200 to
start with.  Fairsharepreemption timeout is 5 mins.
> 1)  Pool1 schedules 300 map tasks first
> 2)  Pool2 then schedules another 300 map tasks
> 3)  Pool3 demands 300 map tasks but doesn't get any slot as all slots are taken.
> 4)  After 5 mins pool3 should preempt 200 map-slots.  Instead of peempting 100 slots
each from pool1 and pool2, the bug would cause it to preempt all 200 slots from pool2 (last
started) causing it to go below fairshare.  This is happening because the preemptTask method
is not reducing the tasks left from a pool while preempting the tasks.  
> The above scenario could be an extreme case but some amount of excess preemption would
happen because of this bug.
> The patch I created was for 0.22.0 but the code fix should work on 0.21  as well as looks
like it has the same bug.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message