hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-714) JobConf.findContainingJar unescapes unnecessarily on Linux
Date Wed, 29 Dec 2010 20:43:45 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12975906#action_12975906
] 

Eli Collins commented on MAPREDUCE-714:
---------------------------------------

+1

This patch looks good to me. Looks like there may be other potential incorrect uses of URLDecode
in the HarFileSystem, minding filling a jira to fix those?

> JobConf.findContainingJar unescapes unnecessarily on Linux
> ----------------------------------------------------------
>
>                 Key: MAPREDUCE-714
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-714
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: mapreduce-714.txt
>
>
> In JobConf.findContainingJar, the path name is decoded using URLDecoder.decode(...).
This was done by Doug in r381794 (commit msg "Un-escape containing jar's path, which is URL-encoded.
 This fixes things primarily on Windows, where paths are likely to contain spaces.") Unfortunately,
jar paths do not appear to be URL encoded on Linux. If you try to use "hadoop jar" on a jar
with a "+" in it, this function decodes it to a space and then the job cannot be submitted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message