Return-Path: Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: (qmail 16153 invoked from network); 23 Nov 2010 11:05:05 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 23 Nov 2010 11:05:05 -0000 Received: (qmail 91406 invoked by uid 500); 23 Nov 2010 11:05:37 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 91301 invoked by uid 500); 23 Nov 2010 11:05:36 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 91293 invoked by uid 99); 23 Nov 2010 11:05:35 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Nov 2010 11:05:35 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Nov 2010 11:05:35 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id oANB5FYS003335 for ; Tue, 23 Nov 2010 11:05:15 GMT Message-ID: <30804678.257011290510315028.JavaMail.jira@thor> Date: Tue, 23 Nov 2010 06:05:15 -0500 (EST) From: "Vinod K V (JIRA)" To: mapreduce-issues@hadoop.apache.org Subject: [jira] Commented: (MAPREDUCE-1978) [Rumen] TraceBuilder should provide recursive input folder scanning MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934803#action_12934803 ] Vinod K V commented on MAPREDUCE-1978: -------------------------------------- The patch looks good to me too. I'd be happy if the test can be modified to do away with all the find/awk kludge - for e.g. {{createHistoryLogsHierarchy()}} knows the list of files being created and so can return the same; for the flat list, {{File.listFiles()}} should suffice. The test results were posted a while ago, please run them once more after the test changes just to be sure. > [Rumen] TraceBuilder should provide recursive input folder scanning > ------------------------------------------------------------------- > > Key: MAPREDUCE-1978 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1978 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: tools/rumen > Reporter: Amar Kamat > Assignee: Ravi Gummadi > Attachments: 1978.patch, 1978.v1.patch > > > Currently, {{TraceBuilder}} assumes that the input is either jobhistory files or a folders containing jobhistory files directly underneath the specified folder. There could be a use cases where the input folder could contain sub-folders containing jobhistory files. Rumen should support such input folders. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.