[ https://issues.apache.org/jira/browse/MAPREDUCE-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928742#action_12928742
]
Patrick Kling commented on MAPREDUCE-2172:
------------------------------------------
The same issue exists in hadoop-common, where test-patch on a clean checkout yields 2 new
findbugs warnings.
> test-patch.properties contains incorrect/version-dependent values of OK_FINDBUGS_WARNINGS
and OK_RELEASEAUDIT_WARNINGS
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2172
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2172
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Environment: FindBugs 1.3.4
> Reporter: Patrick Kling
>
> Running ant test-patch with an empty patch yields 25 findbugs warning and 3 release audit
warnings (rather than the 0 findbugs warnings and 1 release audit warning specified in test-patch.properties):
> {code}
> [exec] -1 overall.
> [exec]
> [exec] +1 @author. The patch does not contain any @author tags.
> [exec]
> [exec] -1 tests included. The patch doesn't appear to include any new or modified
tests.
> [exec] Please justify why no new tests are needed for this patch.
> [exec] Also please list what manual steps were performed to verify
this patch.
> [exec]
> [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
> [exec]
> [exec] +1 javac. The applied patch does not increase the total number of javac compiler
warnings.
> [exec]
> [exec] -1 findbugs. The patch appears to introduce 25 new Findbugs warnings.
> [exec]
> [exec] -1 release audit. The applied patch generated 3 release audit warnings (more
than the trunk's current 1 warnings).
> [exec]
> [exec] +1 system test framework. The patch passed system test framework compile.
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
|