hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-714) JobConf.findContainingJar unescapes unnecessarily on Linux
Date Mon, 15 Nov 2010 03:57:14 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931970#action_12931970
] 

Todd Lipcon commented on MAPREDUCE-714:
---------------------------------------

     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec] 
     [exec]     -1 findbugs.  The patch appears to introduce 13 new Findbugs warnings.
     [exec] 
     [exec]     -1 release audit.  The applied patch generated 2 release audit warnings (more
than the trunk's current 1 warnings).
     [exec] 
     [exec]     +1 system test framework.  The patch passed system test framework compile.

The findbugs warnings are bogus (none related to this patch). The release audit warnings are
also unrelated ("smoke-tests" file and "robots.txt" file). See MAPREDUCE-2172.


> JobConf.findContainingJar unescapes unnecessarily on Linux
> ----------------------------------------------------------
>
>                 Key: MAPREDUCE-714
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-714
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: mapreduce-714.txt
>
>
> In JobConf.findContainingJar, the path name is decoded using URLDecoder.decode(...).
This was done by Doug in r381794 (commit msg "Un-escape containing jar's path, which is URL-encoded.
 This fixes things primarily on Windows, where paths are likely to contain spaces.") Unfortunately,
jar paths do not appear to be URL encoded on Linux. If you try to use "hadoop jar" on a jar
with a "+" in it, this function decodes it to a space and then the job cannot be submitted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message