hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-2034) TestSubmitJob triggers NPE instead of permissions error
Date Wed, 10 Nov 2010 01:23:12 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930404#action_12930404
] 

Todd Lipcon commented on MAPREDUCE-2034:
----------------------------------------

Test patch result:

     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec] 
     [exec]     -1 findbugs.  The patch appears to introduce 13 new Findbugs warnings.
     [exec] 
     [exec]     -1 release audit.  The applied patch generated 2 release audit warnings (more
than the trunk's current 1 warnings).
     [exec] 
     [exec]     +1 system test framework.  The patch passed system test framework compile.

I checked the release audit and findbugs, and it seems like an issue with the test-patch script
-- in both cases the "new" warnings were unrelated to the patch.



> TestSubmitJob triggers NPE instead of permissions error
> -------------------------------------------------------
>
>                 Key: MAPREDUCE-2034
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2034
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Trivial
>         Attachments: mapreduce-2034.txt
>
>
> TestSubmitJob.testSecureJobExecution catches _any_ IOException and assumes a permissions
error has been caught. In fact, it was passing an invalid path name to the NameNode and triggering
an NPE, not a Permission denied error, in one case, but the test was not specific enough to
detect this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message