Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Message-ID: <29682945.63891288031180966.JavaMail.jira@thor>
Date: Mon, 25 Oct 2010 14:26:20 -0400 (EDT)
From: "Ramkumar Vadali (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Subject: [jira] Commented: (MAPREDUCE-2143) HarFileSystem is not able to
 handle spaces in its path
In-Reply-To: <19294455.50471287509307490.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MAPREDUCE-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924666#action_12924666 ] 

Ramkumar Vadali commented on MAPREDUCE-2143:
--------------------------------------------

Test Results

ant test-patch

{code}
     [exec]
     [exec] +1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     +1 tests included.  The patch appears to include 2 new or modified tests.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec]
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
     [exec]
     [exec]     +1 system tests framework.  The patch passed system tests framework compile.
     [exec]
     [exec]
     [exec]
     [exec]
     [exec] ======================================================================
     [exec] ======================================================================
     [exec]     Finished build.
     [exec] ======================================================================
     [exec] ======================================================================
     [exec]
     [exec]
{code}

ant test

There were some unrelated failures that happen in a clean checkout as well.
{code}
    [junit] Test org.apache.hadoop.mapred.TestSequenceFileInputFormat FAILED
    [junit] Test org.apache.hadoop.io.TestSequenceFile FAILED
    [junit] Test org.apache.hadoop.mapred.TestControlledMapReduceJob FAILED (timeout)
    [junit] Test org.apache.hadoop.mapred.TestJobQueueInformation FAILED
    [junit] Test org.apache.hadoop.mapred.TestSequenceFileAsTextInputFormat FAILED
    [junit] Test org.apache.hadoop.mapred.TestSequenceFileInputFilter FAILED
    [junit] Test org.apache.hadoop.mapreduce.lib.input.TestMRSequenceFileAsTextInputFormat FAILED
    [junit] Test org.apache.hadoop.mapreduce.lib.input.TestMRSequenceFileInputFilter FAILED
{code}

I ran ant test on a clean checkout and found that the failing tests fail on the clean checkout as well

{code}

[rvadali@dev502 hadoop-mapred-trunk]$ svn st
X      src/test/bin

Performing status on external item at 'src/test/bin'
[rvadali@dev502 hadoop-mapred-trunk]$ for i in TestSequenceFileInputFormat TestSequenceFile TestControlledMapReduceJob TestJobQueueInformation TestSequenceFileAsTextInputFormat TestSequenceFileInputFilter TestMRSequenceFileAsTextInputFormat TestMRSequenceFileInputFilter; do ant test -Dtestcase=$i 2>&1 > $i.log;done
    [junit] Test org.apache.hadoop.mapred.TestSequenceFileInputFormat FAILED

BUILD FAILED
/data/users/rvadali/apache/hadoop-mapred-trunk/build.xml:800: Tests failed!

Total time: 22 seconds
    [junit] Test org.apache.hadoop.io.TestSequenceFile FAILED

BUILD FAILED
/data/users/rvadali/apache/hadoop-mapred-trunk/build.xml:800: Tests failed!

Total time: 20 seconds
    [junit] Test org.apache.hadoop.mapred.TestControlledMapReduceJob FAILED (timeout)

BUILD FAILED
/data/users/rvadali/apache/hadoop-mapred-trunk/build.xml:800: Tests failed!

Total time: 15 minutes 16 seconds
    [junit] Test org.apache.hadoop.mapred.TestJobQueueInformation FAILED

BUILD FAILED
/data/users/rvadali/apache/hadoop-mapred-trunk/build.xml:800: Tests failed!

Total time: 43 seconds
    [junit] Test org.apache.hadoop.mapred.TestSequenceFileAsTextInputFormat FAILED

BUILD FAILED
/data/users/rvadali/apache/hadoop-mapred-trunk/build.xml:800: Tests failed!

Total time: 18 seconds
    [junit] Test org.apache.hadoop.mapred.TestSequenceFileInputFilter FAILED

BUILD FAILED
/data/users/rvadali/apache/hadoop-mapred-trunk/build.xml:800: Tests failed!

Total time: 19 seconds
    [junit] Test org.apache.hadoop.mapreduce.lib.input.TestMRSequenceFileAsTextInputFormat FAILED

BUILD FAILED
/data/users/rvadali/apache/hadoop-mapred-trunk/build.xml:800: Tests failed!

Total time: 20 seconds
    [junit] Test org.apache.hadoop.mapreduce.lib.input.TestMRSequenceFileInputFilter FAILED

BUILD FAILED
/data/users/rvadali/apache/hadoop-mapred-trunk/build.xml:800: Tests failed!

Total time: 24 seconds
{code}

> HarFileSystem is not able to handle spaces in its path
> ------------------------------------------------------
>
>                 Key: MAPREDUCE-2143
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2143
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: harchive
>            Reporter: Ramkumar Vadali
>            Assignee: Ramkumar Vadali
>             Fix For: 0.22.0
>
>         Attachments: MAPREDUCE-2143.patch
>
>
> If the Path to the HAR contains spaces, Path.getFileSystem() fails. The problem is in HarFileSystem.initialize(), which uses URI.toString() to get a string for getting to the .har suffix. URI.toString() returns a percent-encoded string when the path contains spaces. When this string is subsequently used to get the _index file, we get a FileNotFoundException. The fix is to use URI.getPath().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.