hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mahadev konar (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-2110) add getArchiveIndex to HarFileSystem
Date Tue, 05 Oct 2010 00:58:33 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917845#action_12917845
] 

Mahadev konar commented on MAPREDUCE-2110:
------------------------------------------

This needs to be thought through before exposing an implementation detail in the api's. I
am definitely a -1 on exposing this, unless we can understand the necessity of doing this.


> add getArchiveIndex to HarFileSystem
> ------------------------------------
>
>                 Key: MAPREDUCE-2110
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2110
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Patrick Kling
>            Priority: Minor
>         Attachments: MAPREDUCE-2110.patch
>
>
> This patch adds a public getter for archiveIndex to HarFileSystem, allowing us to access
the index file corresponding to a har file system (useful for raid).
> Index: src/tools/org/apache/hadoop/fs/HarFileSystem.java
> ===================================================================
> --- src/tools/org/apache/hadoop/fs/HarFileSystem.java   (revision 1004421)
> +++ src/tools/org/apache/hadoop/fs/HarFileSystem.java   (working copy)
> @@ -759,6 +759,13 @@
>    }
>    
>    /**
> +   * returns the archive index
> +   */
> +  public Path getArchiveIndex() {
> +    return archiveIndex;
> +  }
> +
> +  /**
>     * return the top level archive path.
>     */
>    public Path getHomeDirectory() {

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message