hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Updated: (MAPREDUCE-2147) JobInProgress has some redundant lines in its ctor
Date Fri, 22 Oct 2010 17:52:06 GMT

     [ https://issues.apache.org/jira/browse/MAPREDUCE-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Doug Cutting updated MAPREDUCE-2147:
------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 0.21.1)
                   0.22.0
           Status: Resolved  (was: Patch Available)

No new tests are required, as this just removes some redundant code.

This is not a regression or serious bug that should be merged into the 0.21 branch, so I changed
it to 0.22.

I committed this.  Thanks, Harsh!

{code}
-1 overall.  

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 system tests framework.  The patch passed system tests framework compile.
{code}

> JobInProgress has some redundant lines in its ctor
> --------------------------------------------------
>
>                 Key: MAPREDUCE-2147
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2147
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: jobtracker
>    Affects Versions: 0.21.0
>         Environment: Not environment related.
>            Reporter: Harsh J Chouraria
>            Assignee: Harsh J Chouraria
>            Priority: Trivial
>             Fix For: 0.22.0
>
>         Attachments: repeated.lines.JIP.r1.diff
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> In the ctor of JobInProgress class that's used by the JT, lines that create the various
lists of TIPs are repeated for no purpose. Might've been due to an overlook I think.
> Attaching a patch that removes these unnecessary repeats of re-init.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message