Return-Path: Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: (qmail 42506 invoked from network); 3 Sep 2010 08:29:58 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 3 Sep 2010 08:29:58 -0000 Received: (qmail 12070 invoked by uid 500); 3 Sep 2010 08:29:58 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 11965 invoked by uid 500); 3 Sep 2010 08:29:56 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 11957 invoked by uid 99); 3 Sep 2010 08:29:55 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Sep 2010 08:29:55 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Sep 2010 08:29:54 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o838TXWh016328 for ; Fri, 3 Sep 2010 08:29:33 GMT Message-ID: <24732364.8021283502573587.JavaMail.jira@thor> Date: Fri, 3 Sep 2010 04:29:33 -0400 (EDT) From: "Hong Tang (JIRA)" To: mapreduce-issues@hadoop.apache.org Subject: [jira] Commented: (MAPREDUCE-2024) 5th JobTracker constructor (for simulator) uses outdated configs, duplicates code In-Reply-To: <30586986.481271282348220750.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-2024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905829#action_12905829 ] Hong Tang commented on MAPREDUCE-2024: -------------------------------------- Is this a duplicate of MAPREDUCE-1001? If so, we probably should keep only one. > 5th JobTracker constructor (for simulator) uses outdated configs, duplicates code > --------------------------------------------------------------------------------- > > Key: MAPREDUCE-2024 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2024 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: jobtracker > Affects Versions: 0.22.0 > Reporter: Greg Roelofs > Priority: Minor > > The fifth JobTracker constructor (JobTracker(final JobConf conf, Clock clock, boolean ignoredForSimulation)) still uses the old "mapred.*" config settings and appears to duplicate much of the code in the fourth (main) ctor. It should be modernized and, ideally, share as much code as possible with the main one in order to minimize simulation drift and the potential for config errors. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.