hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amar Kamat (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1989) Gridmix3 doesn't emit out proper mesage when user resolver is set and no user list is given
Date Fri, 24 Sep 2010 06:10:34 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914344#action_12914344
] 

Amar Kamat commented on MAPREDUCE-1989:
---------------------------------------

Few minor comments:
# In {{GridMix.java}}, _userResolver.getClass().getSimpleName()_ should be _userResolver.getClass().toString()_.
The reason being, there can be a user defined class {{RoundRobinResolver}} but in a different
package. 
# In the testcase, there is an assumption that _writeFile()_ will create the test root directories
and also create the file. One good way of writing the testcase would be
{code}
public void testRoundRobinResolver() throws Exception {
	 String root = initializeTempFile();
         Path userListFile = new Path(root, "users.txt")
         
         // test with missing users file
         .....

         // test with empty users file
         writeUserList(userListFile, "");
         ...

        // test with valid contents
        writeUserList(userListFile, "user,group\n");
{code}
# _testSubmitterResolver()_ and other resolvers should ideally test the return value of _needsTargetUsersList()_
and bail out. If _needsTargetUsersList()_ returns *false* then there is no point in testing
_setTargetUsers()_ as their behavior is undefined.

Rest of the patch seems good.

> Gridmix3 doesn't emit out proper mesage when user resolver is set and no user list is
given
> -------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1989
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1989
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: contrib/gridmix
>            Reporter: Ravi Gummadi
>            Assignee: Ravi Gummadi
>         Attachments: 1989.patch, 1989.v1.1.patch, 1989.v1.patch
>
>
> Currently, Gridmix3 emits out the following mesage when user resolver is set and no user
list is given.
> "Resource null ignored".
> This is not clear/meaningful to user.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message