hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Roelofs (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1125) SerialUtils.cc: deserializeFloat is out of sync with SerialUtils.hh
Date Fri, 10 Sep 2010 05:02:33 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907884#action_12907884
] 

Greg Roelofs commented on MAPREDUCE-1125:
-----------------------------------------

Is this still an issue?  I'm not familiar with the C++ code in question--where does it live?

The patch looks fine as far as it goes (other than the lack of path info in the filenames),
but I'm kind of amazed it ever compiled in the first place.  Is SerialUtils.hh not actually
included in SerialUtils.cc?  Does Hudson even look at this stuff, wherever it lives?

> SerialUtils.cc: deserializeFloat is out of sync with SerialUtils.hh
> -------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1125
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1125
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: pipes
>    Affects Versions: 0.20.1
>            Reporter: Simone Leo
>         Attachments: deserializeFloat.patch
>
>
> {noformat}
> *** SerialUtils.hh ***
>   float deserializeFloat(InStream& stream);
> *** SerialUtils.cc ***
>   void deserializeFloat(float& t, InStream& stream)
>   {
>     char buf[sizeof(float)];
>     stream.read(buf, sizeof(float));
>     XDR xdrs;
>     xdrmem_create(&xdrs, buf, sizeof(float), XDR_DECODE);
>     xdr_float(&xdrs, &t);
>   }
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message