hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ravi Gummadi (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1664) Job Acls affect Queue Acls
Date Thu, 02 Sep 2010 12:32:54 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905489#action_12905489

Ravi Gummadi commented on MAPREDUCE-1664:

>> JobInProgress.java: you accidentally deleted a line if (jobname == null) { jobname
= ""; } +720 line after applying patch and +727 before

This is intentionally removed because jobName cannot be null here.

>> JobSubmittedEvent: Please don't mess with deprecated constructors. Create new ones
as you wish. Once you do this, the changes in rumen/20history parser will not be needed at

As JobSubmittedEvent is flagged as @InterfaceAudience.Private, am fully removing the unnecessary
constructors and keeping the only (modified)one that is needed.

>> TestTaskTrackerLocalization: we were earlier checking permissions of job-acls file.
The file got moved into job-log-dir, but the permissions checks are missed now.

This was not missed. File permissions are validated first and then file content.

Incorporating other review comments.

> Job Acls affect Queue Acls
> --------------------------
>                 Key: MAPREDUCE-1664
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1664
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Ravi Gummadi
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>         Attachments: 1664.20S.3.4.patch, 1664.patch, 1664.qAdminsJobView.20S.v1.6.patch,
M1664y20s-testfix.patch, mr-1664-20-bugfix.patch
> MAPREDUCE-1307 introduced job ACLs for securing job level operations. So in current trunk,
queue ACLs and job ACLs are checked(with AND for both acls) for allowing job level operations.
So for doing operations like killJob, killTask and setJobPriority user should be part of both
mapred.queue.{queuename}.acl-administer-jobs and in mapreduce.job.acl-modify-job. This needs
to change so that users who are part of mapred.queue.{queuename}.acl-administer-jobs will
be able to do killJob,killTask,setJobPriority and users part of mapreduce.job.acl-modify-job
will be able to do killJob,killTask,setJobPriority.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message