Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Message-ID: <27845576.169121280961976606.JavaMail.jira@thor>
Date: Wed, 4 Aug 2010 18:46:16 -0400 (EDT)
From: "Todd Lipcon (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Subject: [jira] Commented: (MAPREDUCE-1994) Linux task-controller determines
 its own path insecurely
In-Reply-To: <1230929.168871280961737334.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MAPREDUCE-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895458#action_12895458 ] 

Todd Lipcon commented on MAPREDUCE-1994:
----------------------------------------

Using its own path in order to detect HADOOP_HOME is probably still insecure, though, since an attacker can hard link the task-controller into their own location. We should probably check that the HADOOP_HOME directory and the config file that it finds both have the same group ID as the task-controller itself, and are not world-writable.

> Linux task-controller determines its own path insecurely
> --------------------------------------------------------
>
>                 Key: MAPREDUCE-1994
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1994
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: security, task-controller
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Priority: Critical
>
> The task-controller uses argv[0] to determine its own path, and then calls stat() on that. Instead it should stat("/proc/self/exe") directly. This is important since argv[0] can be spoofed to point to another program and thus either fool the autodetection of HADOOP_HOME or evade various permissions checks.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.