hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tamas Sarlos (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1834) TestSimulatorDeterministicReplay timesout on trunk
Date Mon, 02 Aug 2010 22:16:17 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894730#action_12894730
] 

Tamas Sarlos commented on MAPREDUCE-1834:
-----------------------------------------

Hong, thanks for finding the root cause. The patch looks ok to me by large, but there are
1 major, and 3 minor issues with it. 

major: 
- FakedConcurrentHashmap.remove(Object key, Object value) does not remove the (key,value)
pair. 

minor:
- The test used to pass if diff is not available, eg. on Windows (Runtime.exec threw an IOException).
Now it fails due to the added Assert.fail in the catch block.
Could you reflect this decision by changing the comments as well or adjust the code to keep
skipping the test on these platforms?

- Replacing the above Runtime.exec with ShellCommandExecutor too would make the code look
more uniform.

- I suggest adding some comments to FakedConcurrentHashMap.java on the need and use of that
class as described in this JIRA. 

Amareshwari & Hemanth, thanks for catching the issue with Process.wait().

> TestSimulatorDeterministicReplay timesout on trunk
> --------------------------------------------------
>
>                 Key: MAPREDUCE-1834
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1834
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: contrib/mumak
>    Affects Versions: 0.21.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Hong Tang
>         Attachments: MAPREDUCE-1834.patch, mr-1834-20100727.patch, mr-1834-20100729.patch,
TestSimulatorDeterministicReplay.log
>
>
> TestSimulatorDeterministicReplay timesout on trunk.
> See hudson patch build http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/216/testReport/org.apache.hadoop.mapred/TestSimulatorDeterministicReplay/testMain/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message