hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amar Kamat (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1762) Add a setValue() method in Counter
Date Wed, 04 Aug 2010 10:32:18 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895210#action_12895210
] 

Amar Kamat commented on MAPREDUCE-1762:
---------------------------------------

Scott/Chris,
I see the following piece of code in this patch
{code}
/**
   * Set this counter by the given value
   * @param the value to set
   */
  public synchronized void setValue(long value) {
    this.value = value;
  }
{code}

Looks like the parameter name 'value' is missing from the Javadoc (i.e @param). This is resulting
in {{test-patch}} failure on trunk. Can one of you look into this?

> Add a setValue() method in Counter
> ----------------------------------
>
>                 Key: MAPREDUCE-1762
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1762
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>    Affects Versions: 0.22.0
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.22.0
>
>         Attachments: M1762-2.patch, MAPREDUCE-1762.1.txt, MAPREDUCE-1762.txt
>
>
> Counters are very useful because of the logging and transmitting are already there.
> It is very convenient to transmit and store numbers. But currently Counter only has an
increment() method.
> It will be nice if there can be a setValue() method in this class that will allow us
to transmit wider variety of information through it.
> What do you think?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message