Return-Path: 
 <mapreduce-issues-return-14152-apmail-hadoop-mapreduce-issues-archive=hadoop.apache.org@hadoop.apache.org>
Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org
Received: (qmail 21469 invoked from network); 2 Jun 2010 18:48:04 -0000
Received: from unknown (HELO mail.apache.org) (140.211.11.3)
  by 140.211.11.9 with SMTP; 2 Jun 2010 18:48:04 -0000
Received: (qmail 81667 invoked by uid 500); 2 Jun 2010 18:48:04 -0000
Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org
Received: (qmail 81579 invoked by uid 500); 2 Jun 2010 18:48:04 -0000
Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:mapreduce-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:mapreduce-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:mapreduce-issues@hadoop.apache.org>
List-Id: <mapreduce-issues.hadoop.apache.org>
Reply-To: mapreduce-issues@hadoop.apache.org
Delivered-To: mailing list mapreduce-issues@hadoop.apache.org
Received: (qmail 81571 invoked by uid 99); 2 Jun 2010 18:48:04 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Jun 2010 18:48:04 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Jun 2010 18:48:02 +0000
Received: from thor (localhost [127.0.0.1])
	by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o52Ilem2012961
	for <mapreduce-issues@hadoop.apache.org>; Wed, 2 Jun 2010 18:47:40 GMT
Message-ID: <31102883.139721275504460529.JavaMail.jira@thor>
Date: Wed, 2 Jun 2010 14:47:40 -0400 (EDT)
From: "Konstantin Boudnik (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Subject: [jira] Commented: (MAPREDUCE-1827) Task Killing/Failing tests for a
 streaming job.
In-Reply-To: <2013263.88321275315882072.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/MAPREDUCE-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874735#action_12874735 ] 

Konstantin Boudnik commented on MAPREDUCE-1827:
-----------------------------------------------

- {{@AfterClass}} method calls {{cluster.tearDown()}} twice. It is really necessary?
- there is a typo
+        "seelp time of 3 secs.", counter > 3 && TaskStatus.State.KILLED ==
- in the {{JobID getJobIdOfRunningStreamJob(String [] runtimeArgs) }} you use {{inputDir}} and {{outputDir}} only once. There's no point to have a special variables to store their String representation for a single use.
- it is a good idea to declare objects you aren't going to modify as {{final}}. I.e.
{noformat}
+    final RunStreamingJob streamJobThread = new RunStreamingJob(conf,
+        streamJob,streamingArgs);
{noformat}
- there's no need to assign {{null]] to a variable and then immediately assign a real object  to it. It's clearer (from the code standpoint) and less clogged (from the logic flow point of view)
- does {{System.getProperty("user.dir")}} points to {{src/contrib/streaming}} during the test execution because otherwise {[/src/test/system/scripts/StreamMapper.sh}} will be looking for the script in a wrong place. According to {{build-contrib.xml}} 
{noformat}
      <sysproperty key="user.dir" value="${build.test}/data"/>
{noformat}
so please make sure your assumptions are correct.


> Task Killing/Failing tests for a streaming job.
> -----------------------------------------------
>
>                 Key: MAPREDUCE-1827
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1827
>             Project: Hadoop Map/Reduce
>          Issue Type: Task
>          Components: test
>            Reporter: Vinay Kumar Thota
>            Assignee: Vinay Kumar Thota
>         Attachments: 1827-ydist-security.patch
>
>
> 1. Set the sleep time for the tasks is 3 seconds and kill the task of streaming job using SIGKILL. After that  verify whether task is killed after 3 seconds or not and also verify whether job is succeeded or not.
> 2. Set the maximum attempts for the maps and reducers are one. make the task to fail and verify whether task  is failed or not.Also verify whether the job is failed or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.