Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Message-ID: <10816219.85101276545195536.JavaMail.jira@thor>
Date: Mon, 14 Jun 2010 15:53:15 -0400 (EDT)
From: "Konstantin Boudnik (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Subject: [jira] Commented: (MAPREDUCE-1854) [herriot] Automate health script
 system test
In-Reply-To: <16964753.26031276191255296.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MAPREDUCE-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878719#action_12878719 ] 

Konstantin Boudnik commented on MAPREDUCE-1854:
-----------------------------------------------

bq. The tasktrackerStatus is a writable object, should'nt the inner class of writable object be public for others to use.
You might be right. However, this field has package-private access. And I believe this has been done for a reason. I am not an expert on MR's internals to tell you one way or another. However, from the common standpoint such widening of permissions isn't advisable.

.bq My real intention of having abstract parent class is have common functionality that can be shared
If in the future we'll see that the number of such shared functions is growing and it become useful to move them all to the common parent we might do just that. However, two functions don't like a good justification to me.

Thanks for the explanations on the Common classes' modifications. They all make sense. I guess these changes will have to end up in a separate JIRA though.

What about getting rid of the script wrappers for ssh functionality and sleep? 

> [herriot] Automate health script system test
> --------------------------------------------
>
>                 Key: MAPREDUCE-1854
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1854
>             Project: Hadoop Map/Reduce
>          Issue Type: New Feature
>          Components: test
>         Environment: Herriot framework
>            Reporter: Balaji Rajagopalan
>            Assignee: Balaji Rajagopalan
>         Attachments: health_script_5.txt
>
>   Original Estimate: 120h
>  Remaining Estimate: 120h
>
> 1. There are three scenarios, first is induce a error from health script, verify that task tracker is blacklisted. 
> 2. Make the health script timeout and verify the task tracker is blacklisted. 
> 3. Make an error in the health script path and make sure the task tracker stays healthy. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.