hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dick King (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1865) [Rumen] Rumen should also support jobhistory files generated using trunk
Date Wed, 16 Jun 2010 17:52:24 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879418#action_12879418
] 

Dick King commented on MAPREDUCE-1865:
--------------------------------------

I have a couple of code review comments on {{mapreduce-1865-v1.2.patch}} .

My small comments are:

1: In {{TestRumenJobTraces.testJobHistoryFilenameProcessing()}}, {{JobID}}'s should probably
be built with the {{JobID(String jtIdentifier, int id)}} constructor.  Also, {{JobID}} jhas
an {{equals(Object)}} method and the raw {{JobID}}'s can therefore be fed into {{assertEquals(String,
Object, Object)}}.

My big comment is: In {{TestRumenJobTraces}} code, can the {{JobHistory}} log files be built
by a minicluster running some trivial job such as a 1 second sleep job, instead of being canned
in {{small-trace-test}} ?

-dk


> [Rumen] Rumen should also support jobhistory files generated using trunk
> ------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1865
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1865
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Amar Kamat
>            Assignee: Amar Kamat
>             Fix For: 0.22.0
>
>         Attachments: mapreduce-1865-v1.2.patch
>
>
> Rumen code in trunk parses and process only jobhistory files from pre-21 hadoop mapreduce
clusters. It should also support jobhistory files generated using trunk.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message