Return-Path: Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: (qmail 20604 invoked from network); 6 May 2010 04:02:13 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 6 May 2010 04:02:13 -0000 Received: (qmail 32606 invoked by uid 500); 6 May 2010 04:02:13 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 32524 invoked by uid 500); 6 May 2010 04:02:13 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 32511 invoked by uid 99); 6 May 2010 04:02:13 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 May 2010 04:02:13 +0000 X-ASF-Spam-Status: No, hits=-1395.1 required=10.0 tests=ALL_TRUSTED,AWL X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 May 2010 04:02:12 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o4641pKw007259 for ; Thu, 6 May 2010 04:01:51 GMT Message-ID: <6686793.1951273118511406.JavaMail.jira@thor> Date: Thu, 6 May 2010 00:01:51 -0400 (EDT) From: "Amareshwari Sriramadasu (JIRA)" To: mapreduce-issues@hadoop.apache.org Subject: [jira] Updated: (MAPREDUCE-1276) Shuffle connection logic needs correction In-Reply-To: <948212691.1260351978213.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated MAPREDUCE-1276: ----------------------------------------------- Attachment: patch-1276-2.txt Patch marks exception during outStream.flush() as not an input exception. Also, moves mapOutputIn.close() to finally block. > Shuffle connection logic needs correction > ------------------------------------------ > > Key: MAPREDUCE-1276 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1276 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: task > Affects Versions: 0.21.0 > Reporter: Jothi Padmanabhan > Assignee: Amareshwari Sriramadasu > Priority: Blocker > Fix For: 0.21.0 > > Attachments: patch-1276-1.txt, patch-1276-2.txt, patch-1276.txt > > > While looking at the code with Amareshwari, we realized that {{Fetcher#copyFromHost}} marks connection as successful when {{url.openConnection}} returns. This is wrong. Connection is done inside implicitly inside {{getInputStream}}; we need to split {{getInputStream}} into {{connect}} and {{getInputStream}} to handle the connection and read time out strategies correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.