Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Message-ID: <23531391.10151272867355883.JavaMail.jira@thor>
Date: Mon, 3 May 2010 02:15:55 -0400 (EDT)
From: "Iyappan Srinivasan (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Subject: [jira] Commented: (MAPREDUCE-1730) Automate test scenario for
 successful/killed jobs' memory is properly removed from jobtracker after
 these jobs retire.
In-Reply-To: <27843972.28021272354332705.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MAPREDUCE-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863247#action_12863247 ] 

Iyappan Srinivasan commented on MAPREDUCE-1730:
-----------------------------------------------

I don't see where the test is really verifying that job in progress object is really removed. 
I don't see any assert conditions specific to retired job in the code. 
 - getJobInfo returns JobinProgress Object. So, the presence or absence of Jobinprogress object
is used to verify job retirement. Assert conditions are present for the presence and absence of this object.

cluster.isJobStarted(jobID);	   -> this method is available in the MRCluster.
- This method is used now in the testcase.

Why are your checking the jobInfo second time? 
- Double checking is removed. There is only one checking now.

If jobinfo available after completion of job, it should fail and shows the message saying that 'Job information is still available after completion of job'.
- This message is added, with a slight change. "Job information is still available after retirement of job"


> Automate test scenario for successful/killed jobs' memory is properly removed from jobtracker after these jobs retire.
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1730
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1730
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>    Affects Versions: 0.22.0
>            Reporter: Iyappan Srinivasan
>             Fix For: 0.22.0
>
>         Attachments: TestJobRetired.patch, TestRetiredJobs.patch
>
>
> Automate using herriot framework,  test scenario for successful/killed jobs' memory is properly removed from jobtracker after these jobs retire.
> This should test when successful and failed jobs are retired,  their jobInProgress object are removed properly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.