From mapreduce-issues-return-13314-apmail-hadoop-mapreduce-issues-archive=hadoop.apache.org@hadoop.apache.org Wed May 05 05:30:30 2010 Return-Path: Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: (qmail 22318 invoked from network); 5 May 2010 05:30:30 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 5 May 2010 05:30:30 -0000 Received: (qmail 71740 invoked by uid 500); 5 May 2010 05:30:30 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 71656 invoked by uid 500); 5 May 2010 05:30:28 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 71648 invoked by uid 99); 5 May 2010 05:30:27 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 May 2010 05:30:27 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 May 2010 05:30:25 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o455U3k5022022 for ; Wed, 5 May 2010 05:30:04 GMT Message-ID: <10027796.13451273037403954.JavaMail.jira@thor> Date: Wed, 5 May 2010 01:30:03 -0400 (EDT) From: "Vinod K V (JIRA)" To: mapreduce-issues@hadoop.apache.org Subject: [jira] Updated: (MAPREDUCE-1707) TaskRunner can get NPE in getting ugi from TaskTracker In-Reply-To: <12680140.136441271321934133.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/MAPREDUCE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod K V updated MAPREDUCE-1707: --------------------------------- Attachment: MAPREDUCE-1707-20100504-ydist.txt Patch for yahoo dist security branch over 20. Not for commit here. > TaskRunner can get NPE in getting ugi from TaskTracker > ------------------------------------------------------ > > Key: MAPREDUCE-1707 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1707 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: tasktracker > Affects Versions: 0.22.0 > Reporter: Amareshwari Sriramadasu > Assignee: Vinod K V > Fix For: 0.22.0 > > Attachments: MAPREDUCE-1707-20100429.txt, MAPREDUCE-1707-20100430.txt, MAPREDUCE-1707-20100504-ydist.txt > > > The following code in TaskRunner can get NPE in the scenario described below. > {code} > UserGroupInformation ugi = > tracker.getRunningJob(t.getJobID()).getUGI(); > {code} > The scenario: > Tracker got a LaunchTaskAction; Task is localized and TaskRunner is started. > Then Tracker got a KillJobAction; This would issue a kill for the task. But, kill will be a no-op because the task did not actually start; The job is removed from runningJobs. > Then if TaskRunner calls tracker.getRunningJob(t.getJobID()), it will be null. > Instead of TaskRunner doing a back call to tasktracker to get the ugi, tracker.getRunningJob(t.getJobID()).getUGI(), ugi should be passed a parameter in the constructor of TaskRunner. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.