hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1505) Cluster class should create the rpc client only when needed
Date Wed, 19 May 2010 22:07:55 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869373#action_12869373
] 

Hadoop QA commented on MAPREDUCE-1505:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12444965/mapreduce-1505--2010-05-19.patch
  against trunk revision 944427.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/193/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/193/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/193/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/193/console

This message is automatically generated.

> Cluster class should create the rpc client only when needed
> -----------------------------------------------------------
>
>                 Key: MAPREDUCE-1505
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1505
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.20.2
>            Reporter: Devaraj Das
>            Assignee: Dick King
>             Fix For: 0.22.0
>
>         Attachments: mapreduce-1505--2010-05-19.patch, MAPREDUCE-1505_yhadoop20.patch,
MAPREDUCE-1505_yhadoop20_9.patch
>
>
> It will be good to have the org.apache.hadoop.mapreduce.Cluster create the rpc client
object only when needed (when a call to the jobtracker is actually required). org.apache.hadoop.mapreduce.Job
constructs the Cluster object internally and in many cases the application that created the
Job object really wants to look at the configuration only. It'd help to not have these connections
to the jobtracker especially when Job is used in the tasks (for e.g., Pig calls mapreduce.FileInputFormat.setInputPath
in the tasks and that requires a Job object to be passed).
> In Hadoop 20, the Job object internally creates the JobClient object, and the same argument
applies there too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message