hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinay Kumar Thota (JIRA)" <j...@apache.org>
Subject [jira] Updated: (MAPREDUCE-1713) Utilities for system tests specific.
Date Wed, 12 May 2010 17:32:43 GMT

     [ https://issues.apache.org/jira/browse/MAPREDUCE-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Vinay Kumar Thota updated MAPREDUCE-1713:
-----------------------------------------

    Attachment: 1713-ydist-security.patch

resetClusterWithDefaultConfig() is unnecessary. Simple restart should work, no ? We should
consider removing ClusterProcessManager.stop(String newConfLocation) as while stopping we
don't need to know the config.

[Vinay]: This comment should be more related to pushconfig task(HADOOP-6752).I just used those
methods in utility class. So, Please update this comment in HADOOP-6752 for removing the ClusterProcessManager.stop(String
newConfLocation) method.

However, I have renamed the resetClusterWithDefaultConfig() method name  to restart()  and
used the start() and stop() methods for restarting the cluster with default config.

 - newConfDir must not be static. It is not required to be class variable
 - AbstractDaemonCluster.restartClusterWithNewConfig can't directly use HadoopDaemonRemoteCluster
concrete implementation
 - getHadoopLocalConfDir in HadoopDaemonRemoteCluster should not be static. This method need
not be in HadoopDaemonRemoteCluster. It can be a private method in AbstractDaemonCluster itself.

Done.

- isJobStarted and isTaskStarted should be in JTClient instead of MRCluster.

??What it makes difference if I moved these methods in JTClient ? Can you please elobrate
more???

- index in waitForClusterToStop() can be removed by directly starting the thread instance.
Done.

Uploaded the latest patch by addressing the given comments.

> Utilities for system tests specific.
> ------------------------------------
>
>                 Key: MAPREDUCE-1713
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1713
>             Project: Hadoop Map/Reduce
>          Issue Type: Task
>          Components: test
>            Reporter: Vinay Kumar Thota
>            Assignee: Vinay Kumar Thota
>         Attachments: 1713-ydist-security.patch, 1713-ydist-security.patch, 1713-ydist-security.patch,
1713-ydist-security.patch, systemtestutils_MR1713.patch, utilsforsystemtest_1713.patch
>
>
> 1.  A method for restarting  the daemon with new configuration.
>       public static  void restartCluster(Hashtable<String,Long> props, String confFile)
throws Exception;
> 2.  A method for resetting the daemon with default configuration.
>       public void resetCluster() throws Exception;
> 3.  A method for waiting until daemon to stop.
>       public  void waitForClusterToStop() throws Exception;
> 4.  A method for waiting until daemon to start.
>       public  void waitForClusterToStart() throws Exception;
> 5.  A method for checking the job whether it has started or not.
>       public boolean isJobStarted(JobID id) throws IOException;
> 6.  A method for checking the task whether it has started or not.
>       public boolean isTaskStarted(TaskInfo taskInfo) throws IOException;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message