hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hemanth Yamijala (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1692) Remove TestStreamedMerge from the streaming tests
Date Thu, 15 Apr 2010 10:54:50 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857271#action_12857271
] 

Hemanth Yamijala commented on MAPREDUCE-1692:
---------------------------------------------

The testcase (introduced in HADOOP-542) is quite obscure because there is no documentation
about what it is intending to test. But trying to decipher:

There are two options used in this testcase - mapsideoutput and inputtagged.

Regarding mapsideoutput, what I could guess was it was using a streaming option that caused
map outputs to be written to a side effect file and verified that the output from these files
was as expected. In the test case, the file was set to be a socket or a local file whose URL
was passed to the 'mapsideoutput' option in Streaming. 

As Sreekanth pointed out, this option is no longer supported, and hence the test code exercising
this option is no longer needed.

inputtagged is still getting added to streaming options in StreamJob. But it doesn't seem
to be used anywhere. Can this be confirmed once again, please ? If confirmed to be unused,
I am +1 for removing the test case. We must probably remove this option from being used in
StreamJob as well, just so it doesn't cause confusion.

If we stick to course to remove the test case, I suggest we remove the target test-unix in
Streaming's build.xml. Because with the patch, it is now identical to the test target.

> Remove TestStreamedMerge from the streaming tests
> -------------------------------------------------
>
>                 Key: MAPREDUCE-1692
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1692
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: contrib/streaming
>            Reporter: Sreekanth Ramakrishnan
>            Priority: Minor
>         Attachments: MAPREDUCE-1692-1.patch, MAPREDUCE-1692-1.patch
>
>
> Currently the {{TestStreamedMerge}} is never run as a part of the streaming test suite,
the code paths which were exercised by the test was removed in HADOOP-1315, so it is better
to remove the testcase from the code base.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message