hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Boudnik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1677) Test scenario for a distributed cache file behaviour when the file is private
Date Tue, 06 Apr 2010 17:59:33 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854087#action_12854087
] 

Konstantin Boudnik commented on MAPREDUCE-1677:
-----------------------------------------------

Looks pretty good. A couple of nits:
- public methods are suppose to have JavaDoc. Tests shouldn't outcast from this rule.
- no all assert message have meaningful message.
- {{boolean b}} can be declared before the outermost loop. The name {{b}} is obscure. Should
be some like {{distCacheIsFound}}
- it is better use a system property for file.delimiter instead of {{"/"}} 
- lines split is non-unified across the test. I.e.
{noformat}
+          Path pathMapredLocalDirUserName = fileStatusMapredLocalDirUserName.
+                                              getPath();
+          FsPermission fsPermMapredLocalDirUserName =
+              fileStatusMapredLocalDirUserName.getPermission();
{noformat}

Please address these and the patch is ready for commit, IMO.

> Test scenario for a distributed cache file behaviour  when the file is private
> ------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1677
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1677
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Iyappan Srinivasan
>            Assignee: Iyappan Srinivasan
>         Attachments: TestDistributedCachePrivateFile.patch
>
>
>  Verify the Distributed Cache functionality.
>  This test scenario is for a distributed cache file behaviour  when the file is private.
Once a job uses a distributed 
> cache file with private permissions that file is stored in the  mapred.local.dir, under
the directory which has the same name 
>  as job submitter's username. The directory has 700 permission  and the file under it,
should have 777 permissions. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message