hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amareshwari Sriramadasu (JIRA)" <j...@apache.org>
Subject [jira] Updated: (MAPREDUCE-1662) TaskRunner.prepare() and close() can be removed
Date Thu, 01 Apr 2010 08:35:28 GMT

     [ https://issues.apache.org/jira/browse/MAPREDUCE-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Amareshwari Sriramadasu updated MAPREDUCE-1662:
-----------------------------------------------

    Attachment: patch-1662.txt

Patch removes TaskRunner.prepare(). 
ReduceTaskRunner.close() sets a status "closed" on the Progress object. So, patch does not
remove TaskRunner.close(), but removes mapOutputFile.removeAll() from close() methods in MapTaskRunner
and ReduceTaskRunner.

> TaskRunner.prepare() and close() can be removed
> -----------------------------------------------
>
>                 Key: MAPREDUCE-1662
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1662
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tasktracker
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>             Fix For: 0.22.0
>
>         Attachments: patch-1662.txt
>
>
> TaskRunner.prepare() and close() methods call only mapOutputFile.removeAll(). The removeAll()
call is a always a no-op in prepare(), because the directory is always empty during start
up of the task. The removeAll() call in close() is useless, because it is followed by a attempt
directory cleanup. Since the map output files are in attempt directory,  the call to close()
is useless.
> After MAPREDUCE-842, these calls are under TaskTracker space, passing the wrong conf.
Now, the calls do not make sense at all.
> I think we can remove the methods.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message