hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinay Kumar Thota (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1671) Test scenario for "Killing Task Attempt id till job fails"
Date Tue, 20 Apr 2010 10:02:51 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858801#action_12858801
] 

Vinay Kumar Thota commented on MAPREDUCE-1671:
----------------------------------------------

I have some trivial comments and mainly on code formatting.

+       if(!taskInfo.isSetupOrCleanup()){ - Check the indentation, no spaces after 'if' and
before '{'

TaskCompletionEvent[] taskCompletionEvents =  jobClient.new
+        NetworkedJob(jInfo.getStatus()).getTaskCompletionEvents(0); - Check the indentation


+      if (count > 10)
+        Assert.fail("Since the task attemptid is not appearing in the" +
+            "TaskCompletionEvent, it seems this task attempt was not killed");

As per the java coding conventions the condition statements should always start and ends with
braces even if it has one statement.
Should check all the places.

I could see indentation issue for continuation lines in many places.The continuation line
should have 8 spaces from the statement where it started.


> Test scenario for "Killing Task Attempt id till job fails"
> ----------------------------------------------------------
>
>                 Key: MAPREDUCE-1671
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1671
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>            Reporter: Iyappan Srinivasan
>            Assignee: Iyappan Srinivasan
>         Attachments: TEST-org.apache.hadoop.mapred.TestTaskKilling.txt, TestTaskKilling.patch,
TestTaskKilling.patch, TestTaskKilling.patch, TestTaskKilling.patch
>
>
> 1) In a  job, kill the task attemptid of one task.  Whenever that task  tries to run
again with another task atempt id for mapred.map.max.attempts times, kill that task attempt
id. After the mapred.map.max.attempts times, the whole job should get killed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message