hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1662) TaskRunner.prepare() and close() can be removed
Date Thu, 01 Apr 2010 21:40:27 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852564#action_12852564

Hadoop QA commented on MAPREDUCE-1662:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision 929712.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/87/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/87/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/87/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/87/console

This message is automatically generated.

> TaskRunner.prepare() and close() can be removed
> -----------------------------------------------
>                 Key: MAPREDUCE-1662
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1662
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tasktracker
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>             Fix For: 0.22.0
>         Attachments: patch-1662.txt
> TaskRunner.prepare() and close() methods call only mapOutputFile.removeAll(). The removeAll()
call is a always a no-op in prepare(), because the directory is always empty during start
up of the task. The removeAll() call in close() is useless, because it is followed by a attempt
directory cleanup. Since the map output files are in attempt directory,  the call to close()
is useless.
> After MAPREDUCE-842, these calls are under TaskTracker space, passing the wrong conf.
Now, the calls do not make sense at all.
> I think we can remove the methods.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message