Return-Path: Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: (qmail 53675 invoked from network); 17 Mar 2010 23:48:49 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 17 Mar 2010 23:48:49 -0000 Received: (qmail 96411 invoked by uid 500); 17 Mar 2010 23:48:48 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 96354 invoked by uid 500); 17 Mar 2010 23:48:48 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 96081 invoked by uid 99); 17 Mar 2010 23:48:48 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Mar 2010 23:48:48 +0000 X-ASF-Spam-Status: No, hits=-1049.1 required=10.0 tests=ALL_TRUSTED,AWL X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Mar 2010 23:48:47 +0000 Received: from brutus.apache.org (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 8111A234C4C7 for ; Wed, 17 Mar 2010 23:48:27 +0000 (UTC) Message-ID: <141090738.329731268869707527.JavaMail.jira@brutus.apache.org> Date: Wed, 17 Mar 2010 23:48:27 +0000 (UTC) From: "Hadoop QA (JIRA)" To: mapreduce-issues@hadoop.apache.org Subject: [jira] Commented: (MAPREDUCE-1593) [Rumen] Improvements to random seed generation In-Reply-To: <584164053.213981268346987203.JavaMail.jira@brutus.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846679#action_12846679 ] Hadoop QA commented on MAPREDUCE-1593: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12438953/MAPREDUCE-1593-20100311-dup.patch against trunk revision 923907. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/36/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/36/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/36/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/36/console This message is automatically generated. > [Rumen] Improvements to random seed generation > ----------------------------------------------- > > Key: MAPREDUCE-1593 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1593 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Affects Versions: 0.21.0, 0.22.0 > Reporter: Tamas Sarlos > Assignee: Tamas Sarlos > Priority: Trivial > Fix For: 0.21.0, 0.22.0 > > Attachments: MAPREDUCE-1593-20100311-dup.patch, MAPREDUCE-1593-20100311.patch > > > RandomSeedGenerator introduced in MAPREDUCE-1306 could be more efficient by reusing the MD5 object across calls. Wrapping the MD5 in a ThreadLocal makes the call thread safe as well. Neither of these is an issue with the current client, the mumak simulator, but the changes are small and make the code more useful in the future. Thanks to Chris Douglas for the suggestion. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.