hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rodrigo Schmidt (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1579) archive: check and possibly replace the space charater in paths
Date Wed, 10 Mar 2010 20:34:27 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843759#action_12843759
] 

Rodrigo Schmidt commented on MAPREDUCE-1579:
--------------------------------------------

Nicholas, the patch looks good and you did some great refactoring also. Just two minor things:

1) I think your patch file also contains the changes from MAPREDUCE-1578 and it probably won't
merge well. You might want to merge it with trunk and submit it again.

2) The LOG.info() calls might not help much, specially the first one.


> archive: check and possibly replace the space charater in paths
> ---------------------------------------------------------------
>
>                 Key: MAPREDUCE-1579
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1579
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: harchive
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Mahadev konar
>         Attachments: m1579_20100310.patch
>
>
> Since the space character is used as a separator in the index files, it won't work if
there are spaces in the path (see also HADOOP-6591).  The archive tools should 
> # detect if there are spaces in the paths and 
> # provide an option to replace it with some other characters.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message