hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod K V (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1542) Deprecate mapred.permissions.supergroup in favor of hadoop.cluster.administrators
Date Tue, 09 Mar 2010 04:45:27 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842906#action_12842906
] 

Vinod K V commented on MAPREDUCE-1542:
--------------------------------------

The patch has gone stale, needs update w.r.t TestWebUIAuthorization.

JobTracker.java
 - The log statement after building acls should also log the configured admin acls. Same in
TaskTracker.java
 - {{buildAdminACLs()}}
   -- Instead of getting the new configruation property and comparing it with mrOwner, it
is better to create a {{Configuration}} object without loading default resources (Hemanth's
smart tip!), get the configuration parameter and compare it will null.
   -- If the new configuration is not present, there is no need for augmenting mrOwner also
to the ACL as we specially check for mrOwner everywhere. Correspondingly {{buildACLs()}} doesn't
need to take mrOwner as a parameter.

Fix the javadoc for MR_SUPERGROUP and JT_SUPERGROUP. The link should be "{@link CommonConfigurationKeys#HADOOP_CLUSTER_ADMINISTRATORS_PROPERTY}"

All tests should use the new configuration property only. We can add a simple unit test for
handling deprecation in TestJobConf.

Still, there are some occurrences of the old configuration property. Can you do a (case-insensitive)
grep for 'supergroup' on the source code and replace'em all?

> Deprecate mapred.permissions.supergroup in favor of hadoop.cluster.administrators
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1542
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1542
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: security
>            Reporter: Vinod K V
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>         Attachments: 1542.patch
>
>
> HADOOP-6568 added the configuration {{hadoop.cluster.administrators}} through which admins
can configure who the superusers/supergroups for the cluster are. MAPREDUCE itself already
has {{mapred.permissions.supergroup}} (which is just a single group). As agreed upon at HADOOP-6568,
this should be deprecated in favor of {{hadoop.cluster.administrators}}.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message