hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amareshwari Sriramadasu (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1480) CombineFileRecordReader does not properly initialize child RecordReader
Date Mon, 01 Mar 2010 07:29:05 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839578#action_12839578
] 

Amareshwari Sriramadasu commented on MAPREDUCE-1480:
----------------------------------------------------

Looked at the patch. 
I'm not sure about the correctness of progress calculation changes. Changes for RecordReader.initialize()
look fine.
Dhruba, Can you look at progress calculation change in the attached patch?

Can you extend the test case to have more than one file, so that the method CombineFileRecordReader.initNextRecordReader()
will also be tested? With the current test only the CombineFileRecordReader's constructor
and initialize() method are tested.

> CombineFileRecordReader does not properly initialize child RecordReader
> -----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1480
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1480
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Aaron Kimball
>            Assignee: Aaron Kimball
>         Attachments: MAPREDUCE-1480.2.patch, MAPREDUCE-1480.patch
>
>
> CombineFileRecordReader instantiates child RecordReader instances but never calls their
initialize() method to give them the proper TaskAttemptContext.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message