hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1593) [Rumen] Improvements to random seed generation
Date Fri, 12 Mar 2010 11:27:27 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844462#action_12844462
] 

Hadoop QA commented on MAPREDUCE-1593:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12438552/MAPREDUCE-1593-20100311.patch
  against trunk revision 922047.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/522/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/522/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/522/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/522/console

This message is automatically generated.

> [Rumen] Improvements to random seed generation 
> -----------------------------------------------
>
>                 Key: MAPREDUCE-1593
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1593
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Tamas Sarlos
>            Assignee: Tamas Sarlos
>            Priority: Trivial
>             Fix For: 0.21.0, 0.22.0
>
>         Attachments: MAPREDUCE-1593-20100311.patch
>
>
> RandomSeedGenerator introduced in MAPREDUCE-1306 could be more efficient by reusing the
MD5 object across calls. Wrapping the MD5 in a ThreadLocal makes the call thread safe as well.
Neither of these is an issue with the current client, the mumak simulator, but the changes
are small and make the code more useful in the future. Thanks to Chris Douglas for the suggestion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message