hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Boudnik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1616) Automate system test case for checking the file permissions in mapred.local.dir
Date Wed, 31 Mar 2010 17:49:27 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851992#action_12851992
] 

Konstantin Boudnik commented on MAPREDUCE-1616:
-----------------------------------------------

Oops. the previous comment is partially wrong, actually. The testcase uses a mix of JUnit
v3 and v4 APIs. As in
{noformat}
+import junit.framework.Assert;
...
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.Test;
{noformat}

Also, instead of creating new objects for every assert statement you might want to add some
constants like
{noformat}
private final FsPermission PERM_777 = new FsPermission("777"));
...
  Assert.assertTrue(fsPerm.equals(PERM_777));
{noformat}
This way the code will be more clean/readable.


> Automate system test case for checking the file permissions in mapred.local.dir
> -------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1616
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1616
>             Project: Hadoop Map/Reduce
>          Issue Type: New Feature
>    Affects Versions: 0.20.3
>         Environment: Herriot framework is required for running the test. 
>            Reporter: Balaji Rajagopalan
>         Attachments: patch_1655.txt, patch_3392207_7.txt
>
>   Original Estimate: 0.27h
>  Remaining Estimate: 0.27h
>
> The file under mapred.local.dir permission must be recursively tested when the task is
running, for this use the controllable task, so the temporary file permission can be checked.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message