hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hemanth Yamijala (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1422) Changing permissions of files/dirs under job-work-dir may be needed sothat cleaning up of job-dir in all mapred-local-directories succeeds always
Date Mon, 08 Mar 2010 18:45:27 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842765#action_12842765
] 

Hemanth Yamijala commented on MAPREDUCE-1422:
---------------------------------------------

Amar, I think you need to write files into the task directory and not task-work directory
to simulate the case I mentioned in my comments above. AFAIK, task work directory is always
cleaned up, but task directory is not cleaned up sometimes until a job cleanup happens. I
would request we make the test to simulate the exact scenario. Also, just so to avoid false
positives concerning this kind of loop:
{code}
    for (Path p : tPaths) {
      if (tracker.getLocalFileSystem().exists(p)) {
        createFileAndSetPermissions(localizedJobConf, p);
      }
    }
{code}
can you please verify at least one path existed ? I am worried that if for some reason no
paths exist, then the code will run through without doing any special removal at all.

> Changing permissions of files/dirs under job-work-dir may be needed sothat cleaning up
of job-dir in all mapred-local-directories succeeds always
> -------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1422
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1422
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tasktracker
>            Reporter: Ravi Gummadi
>            Assignee: Amar Kamat
>         Attachments: mapreduce-1422-test-v1.0.patch, mapreduce-1422-v1.4.2.patch, mapreduce-1422-v1.5.2.patch
>
>
> After MAPREDUCE-896, if LinuxTaskController is set in config, task-controller binary
is launched for changing permissions of taskAttemptDir and taskWorkDir before cleaning up
of these directories sothat cleanup will be succeeded even if user had created files/dirs
under taskAttemptDir or taskWorkDir with non-writable permissions. Users can't create files/dirs
under job-dir directly as we set 2570 for job-dir. But as job-work-dir has 2770 permissions
and user can create files/dirs under job-work-dir with non-writable permissions, Changing
permissions of files/dirs under job-work-dir may be needed sothat cleaning up of job-dir in
all mapred-local-directories succeeds always.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message