hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Douglas (JIRA)" <j...@apache.org>
Subject [jira] Updated: (MAPREDUCE-1480) CombineFileRecordReader does not properly initialize child RecordReader
Date Tue, 23 Mar 2010 00:11:27 GMT

     [ https://issues.apache.org/jira/browse/MAPREDUCE-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chris Douglas updated MAPREDUCE-1480:
-------------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

+1

I committed this. Thanks, Aaron!

Minor nit:
{noformat}
+      curReader =  rrConstructor.newInstance(new Object [] 
+                            {split, context, Integer.valueOf(idx)});
{noformat}
{{Constructor::newInstance(Object...)}} supports the syntactic sugar eliding the explicit
{{Object[]}} creation.

> CombineFileRecordReader does not properly initialize child RecordReader
> -----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1480
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1480
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Aaron Kimball
>            Assignee: Aaron Kimball
>         Attachments: MAPREDUCE-1480.2.patch, MAPREDUCE-1480.3.patch, MAPREDUCE-1480.4.patch,
MAPREDUCE-1480.5.patch, MAPREDUCE-1480.patch
>
>
> CombineFileRecordReader instantiates child RecordReader instances but never calls their
initialize() method to give them the proper TaskAttemptContext.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message