Return-Path: Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: (qmail 60857 invoked from network); 25 Feb 2010 01:22:48 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 25 Feb 2010 01:22:48 -0000 Received: (qmail 56340 invoked by uid 500); 25 Feb 2010 01:22:48 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 56259 invoked by uid 500); 25 Feb 2010 01:22:48 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 56250 invoked by uid 99); 25 Feb 2010 01:22:48 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Feb 2010 01:22:48 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Feb 2010 01:22:48 +0000 Received: from brutus.apache.org (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id F3418234C1F2 for ; Wed, 24 Feb 2010 17:22:27 -0800 (PST) Message-ID: <1257379381.513151267060947995.JavaMail.jira@brutus.apache.org> Date: Thu, 25 Feb 2010 01:22:27 +0000 (UTC) From: "Matei Zaharia (JIRA)" To: mapreduce-issues@hadoop.apache.org Subject: [jira] Commented: (MAPREDUCE-1499) JobTracker.finalizeJob inverts lock order and causes potential deadlock In-Reply-To: <970618266.330281266395667954.JavaMail.jira@brutus.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838131#action_12838131 ] Matei Zaharia commented on MAPREDUCE-1499: ------------------------------------------ The problem in MAPREDUCE-1436 only happened with a backport of the trunk fair scheduler to 0.20. It probably won't happen with the 0.20 fair scheduler. However, anyone packaging a distribution that includes a backport of the fair scheduler should look into it. As I mentioned in MAPREDUCE-1436, the fix (adding a lock around the TaskTrackerManager in update() is simple and is unlikely to have a major impact on performance. > JobTracker.finalizeJob inverts lock order and causes potential deadlock > ----------------------------------------------------------------------- > > Key: MAPREDUCE-1499 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1499 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: jobtracker > Affects Versions: 0.20.1, 0.20.2 > Reporter: Todd Lipcon > Assignee: Aaron Kimball > Priority: Critical > Attachments: jcarder_result_1.dot.png, jcarder_result_8.dot.png, MAPREDUCE-1499.patch > > > This issue was brought up by Matei in MAPREDUCE-1436 as a fairsched bug, but it turns out it's a JT bug even with the fifo scheduler in unpatched 0.20.2. JobTracker.finalizeJob locks JT.jobs, JT.taskScheduler, etc, having gotten the JIP log before the JT lock. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.