Return-Path: Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: (qmail 1949 invoked from network); 9 Feb 2010 17:15:49 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 9 Feb 2010 17:15:49 -0000 Received: (qmail 57437 invoked by uid 500); 9 Feb 2010 17:15:49 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 57362 invoked by uid 500); 9 Feb 2010 17:15:48 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 57352 invoked by uid 99); 9 Feb 2010 17:15:48 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Feb 2010 17:15:48 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Feb 2010 17:15:48 +0000 Received: from brutus.apache.org (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id F0615234C4A8 for ; Tue, 9 Feb 2010 09:15:27 -0800 (PST) Message-ID: <1000003134.153851265735727983.JavaMail.jira@brutus.apache.org> Date: Tue, 9 Feb 2010 17:15:27 +0000 (UTC) From: "Arun C Murthy (JIRA)" To: mapreduce-issues@hadoop.apache.org Subject: [jira] Commented: (MAPREDUCE-1471) FileOutputCommitter does not safely clean up it's temporary files In-Reply-To: <1925441865.151161265729128221.JavaMail.jira@brutus.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831546#action_12831546 ] Arun C Murthy commented on MAPREDUCE-1471: ------------------------------------------ Jim, all file-based output-formats check to ensure that their output-directory is *not* present when they start i.e. 'working_path' is owned by one and only one job, hence this behaviour is correct. > FileOutputCommitter does not safely clean up it's temporary files > ----------------------------------------------------------------- > > Key: MAPREDUCE-1471 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1471 > Project: Hadoop Map/Reduce > Issue Type: Bug > Affects Versions: 0.20.1 > Reporter: Jim Finnessy > Original Estimate: 4h > Remaining Estimate: 4h > > When the FileOutputCommitter cleans up during it's cleanupJob method, it potentially deletes the temporary files of other concurrent jobs. > Since all the temporary files for all concurrent jobs are written to working_path/_temporary/ any concurrent tasks that have the same working_path will remove all currently executing jobs when it removes working_path/_temporary during job cleanup. > If the file name output is guaranteed by the client application to be unique, the temporary files/directories should also be guaranteed to be unique to avoid this problem. Suggest modifying cleanupJob to only remove files that it created itself. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.