hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devaraj Das (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1430) JobTracker should be able to renew delegation tokens for the jobs
Date Fri, 19 Feb 2010 21:12:29 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835951#action_12835951
] 

Devaraj Das commented on MAPREDUCE-1430:
----------------------------------------

Looks good. But I must admit that I missed a point in my earlier review. The removal of the
token when a renewal fails should only be removing that token. Now you remove all the tokens.
This may be too aggressive. So i'd suggest add a method removeDelegationTokenRenewal(JobID,
Token) and do an exact match of the token and remove that (and that method gets called from
renewDelegationToken on an exception). In this implementation, you needn't call cancelToken
since the token is invalid already. 
The current implementation of removeDelegationTokenRenewal(JobID) should only be called from
JobInProgress then.

> JobTracker should be able to renew delegation tokens for the jobs
> -----------------------------------------------------------------
>
>                 Key: MAPREDUCE-1430
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1430
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: jobtracker
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Boris Shkolnik
>             Fix For: 0.22.0
>
>         Attachments: MAPREDUCE-1430-12.patch, MAPREDUCE-1430-13.patch, MAPREDUCE-1430-5.patch,
MAPREDUCE-1430-6.patch, MAPREDUCE-1430-8.patch
>
>
> JobTracker should automatically renew delegation tokens for the jobs it is currently
running.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message