hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hemanth Yamijala (JIRA)" <j...@apache.org>
Subject [jira] Updated: (MAPREDUCE-1403) Save file-sizes of each of the artifacts in DistributedCache in the JobConf
Date Sat, 13 Feb 2010 09:37:27 GMT

     [ https://issues.apache.org/jira/browse/MAPREDUCE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Hemanth Yamijala updated MAPREDUCE-1403:
----------------------------------------

    Attachment: MAPREDUCE-1403_yhadoop20-1.patch

Arun, patch looks fine. There were a few minor nits that I have fixed in the attached patch:

- In DistributedCache.java, I refactored getTimestamp to reuse getFileStatus, as the entire
code was duplicated.
- In JobClient.java, there was an extraneous String.valueOf when constructing the modification
time buffer. Something like:
{code}
+        new StringBuffer(String.valueOf(
+            String.valueOf(status.getModificationTime())));
{code}
Fixed that to remove the extraneous call.
- In MRCaching, moved a System.err.println to System.out.println, as it the follows the rest
of the output and the debug statements now come along with rest of the output - so I thought
it would be easier to debug if required.

Please verify the changes once.

> Save file-sizes of each of the artifacts in DistributedCache in the JobConf
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1403
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1403
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: client
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>             Fix For: 0.22.0
>
>         Attachments: MAPREDUCE-1403_yhadoop20-1.patch, MAPREDUCE-1403_yhadoop20.patch
>
>
> It would be a useful metric to collect... potentially GridMix could use it to emulate
jobs which use the DistributedCache.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message