hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hemanth Yamijala (JIRA)" <j...@apache.org>
Subject [jira] Updated: (MAPREDUCE-1476) committer.needsTaskCommit should not be called for a task cleanup attempt
Date Mon, 15 Feb 2010 05:47:28 GMT

     [ https://issues.apache.org/jira/browse/MAPREDUCE-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Hemanth Yamijala updated MAPREDUCE-1476:

    Attachment: patch-1476-2.txt

Amarsri and I discussed the test case in the original patch and decided to retain it as a
regression test for the bug that triggered this JIRA, in addition to more targeted unit tests
that I wrote.

The new patch has the following changes, in line with the above decision:
- Makes editorial changes to the regression test - adding a few more comments, refactoring
for more explanatory names, etc.
- Uses a different committer for the targeted unit tests that always return true for needTaskCommit.
- Fixes TestTaskCleanup.tearDown to call super.

Amarsri, can you please take a quick look at the changes and run through Hudson ?

> committer.needsTaskCommit should not be called for a task cleanup attempt
> -------------------------------------------------------------------------
>                 Key: MAPREDUCE-1476
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1476
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.1
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.22.0
>         Attachments: patch-1476-1.txt, patch-1476-2.txt, patch-1476.txt
> Currently, Task.done() calls committer.needsTaskCommit() to know whether it needs a commit
or not. This need not be called for task cleanup attempt as no commit is required for a cleanup
> Due to MAPREDUCE-1409, we saw a case where cleanup attempt went into COMMIT_PENDING state.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message