hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Douglas (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1378) Args in job details links on jobhistory.jsp are not URL encoded
Date Tue, 16 Feb 2010 08:02:28 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834117#action_12834117
] 

Chris Douglas commented on MAPREDUCE-1378:
------------------------------------------

It's hard to say "no" to a cleaner, layered architecture, but the breadth of such a change
probably exceeds the scope of this issue. If you're willing to undertake that work, please
file a separate JIRA and provide details there. Improving the structure of the jsps would
be a welcome enhancement.

A unit test for this would be awkward to write, but an explanation of how it was tested is
a minimal prerequisite to committing the fix.

> Args in job details links on jobhistory.jsp are not URL encoded
> ---------------------------------------------------------------
>
>                 Key: MAPREDUCE-1378
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1378
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobtracker
>    Affects Versions: 0.22.0
>            Reporter: E. Sammer
>            Priority: Trivial
>         Attachments: MAPREDUCE-1378.patch
>
>
> The logFile argument in the job links on the JT jobhistory.jsp page is not properly URL
encoded leading to links that result in 500 errors. I found the issue while working with the
Cloudera distro which contained a plus ('+') in the path which is interpreted as a space character
(%20) by Firefox. Here is the (trimmed) URL. Note the hadoop-0.20.1+152 directory which should
be hadoop-0.20.1%2B152. I have created a patch against current ASF svn trunk but it is untested
(although the jsp compiles to a class file ok).
> A job link from http://host:50030/jobhistory.jsp:
> http://host:50030/jobdetailshistory.jsp?jobid=job_201001141235_0001&logFile=file:/Users/esammer/hadoop-0.20.1+152/logs/history/done/...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message