hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1414) TestRecoveryManager can spin waiting for a job to be half done
Date Mon, 15 Feb 2010 10:51:27 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833757#action_12833757
] 

Steve Loughran commented on MAPREDUCE-1414:
-------------------------------------------

I disagree. <junit> will timeout but it reacts by killing the process, creating an empy
XML file. when the XSL transforms are applied to create HTML docs, <junitreport> will
mention the missing file and skip it. Your test HTML reports -which may be on some remote
hudson server, after all- won't contain any information as to why your build failed, except
you get emails saying "junit test run failed". 

Having the test recognise and handle a situation which at least one person (me)  has encountered
would eliminate this, and I don't see why it should be rejected. The more robust your test
harness is, the better.

>  TestRecoveryManager can spin waiting for a job to be half done
> ---------------------------------------------------------------
>
>                 Key: MAPREDUCE-1414
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1414
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>             Fix For: 0.22.0
>
>         Attachments: MAPREDUCE-1414.patch
>
>
> This is something I've seen: the TestRecoveryManager spinning forever waiting for a job
to get half done. The test runner will eventually kill it, but that loses any log and chance
of finding the problem.
> Solution: have a timeout on how long you wait for the job

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message